Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in ClosableDialog #8480

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Aug 15, 2024

Issue
Resolves #8465

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Aug 15, 2024
@eivindjahren eivindjahren requested a review from sondreso August 15, 2024 11:49
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.66%. Comparing base (aad5994) to head (d009841).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8480      +/-   ##
==========================================
- Coverage   90.69%   90.66%   -0.04%     
==========================================
  Files         345      345              
  Lines       20981    20981              
==========================================
- Hits        19029    19022       -7     
- Misses       1952     1959       +7     
Flag Coverage Δ
gui-tests 75.92% <100.00%> (-0.03%) ⬇️
integration-tests 53.95% <0.00%> (-0.01%) ⬇️
unit-tests 68.66% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-el andreas-el changed the title Fix a bug in CosableDialog Fix a bug in ClosableDialog Aug 15, 2024
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Using the correct name is always a good idea. 💡

@eivindjahren eivindjahren merged commit 78e3450 into equinor:main Aug 16, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Esc button crashes gui if event viewer is open
4 participants