Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports version 10_2 #8503

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

andreas-el
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el changed the title Backports version 10 2 Backports version 10_2 Aug 16, 2024
@andreas-el andreas-el self-assigned this Aug 16, 2024
@andreas-el andreas-el merged commit bc8c383 into equinor:version-10.2 Aug 16, 2024
38 checks passed
@andreas-el andreas-el deleted the backports_version-10_2 branch August 16, 2024 13:15
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.46269% with 47 lines in your changes missing coverage. Please review.

Project coverage is 87.17%. Comparing base (8aa13a5) to head (6b78c32).
Report is 9 commits behind head on version-10.2.

Files Patch % Lines
src/ert/gui/plottery/plots/std_dev.py 19.04% 17 Missing ⚠️
src/ert/gui/tools/plot/color_chooser.py 64.51% 11 Missing ⚠️
src/ert/gui/tools/plot/plot_api.py 76.47% 8 Missing ⚠️
src/ert/dark_storage/endpoints/records.py 33.33% 6 Missing ⚠️
src/ert/gui/ertwidgets/copy_button.py 87.50% 3 Missing ⚠️
...gui/simulation/multiple_data_assimilation_panel.py 93.75% 1 Missing ⚠️
src/ert/gui/tools/plot/plot_window.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           version-10.2    #8503      +/-   ##
================================================
+ Coverage         87.05%   87.17%   +0.12%     
================================================
  Files               381      379       -2     
  Lines             23665    23638      -27     
  Branches            626      628       +2     
================================================
+ Hits              20602    20607       +5     
+ Misses             2984     2958      -26     
+ Partials             79       73       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants