Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select first realizations by default in gui #8507

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

AugustoMagalhaes
Copy link
Contributor

@AugustoMagalhaes AugustoMagalhaes commented Aug 19, 2024

Issue
Resolves #8419

Approach
Now when run_dialog is opened, it shows the first realization as default in job_overview and in realization list with proper color highlighting.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el
Copy link
Contributor

Have tried to raise in scheduler, changing permissions on storage and output folders. Not able to break this.

@@ -540,7 +540,6 @@ def test_run_dialog_fm_label_show_correct_info(
assert fm_step_model._real == 0

fm_step_label = run_dialog.findChild(QLabel, name="fm_step_label")
assert not fm_step_label.text()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can seemingly do assert fm_step_label.text() == "Realization id 0 in iteration 0" here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That is correct. I'll update this! 👍

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@andreas-el andreas-el merged commit 7e0f793 into equinor:main Nov 27, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Select first realizations by default to avoid empty details window
3 participants