Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where seed was not set for manual initialization #8539

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 21, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

sondreso
sondreso previously approved these changes Aug 21, 2024
@oyvindeide oyvindeide added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Aug 21, 2024
@oyvindeide oyvindeide enabled auto-merge (rebase) August 21, 2024 11:33
@oyvindeide oyvindeide merged commit c6f3091 into equinor:main Aug 21, 2024
35 checks passed
@oyvindeide oyvindeide deleted the fix_random_Seed branch August 21, 2024 11:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.68%. Comparing base (02f996b) to head (894676a).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8539      +/-   ##
==========================================
+ Coverage   90.63%   90.68%   +0.04%     
==========================================
  Files         342      342              
  Lines       20901    20947      +46     
==========================================
+ Hits        18944    18995      +51     
+ Misses       1957     1952       -5     
Flag Coverage Δ
gui-tests 75.85% <ø> (-0.02%) ⬇️
integration-tests 54.08% <ø> (+0.01%) ⬆️
unit-tests 68.80% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants