Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for missing response #8542

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 21, 2024

Got a question about a confusing error message, so suggest an improvement.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@sondreso sondreso added the release-notes:improvement Automatically categorise as improvement in release notes label Aug 21, 2024
@oyvindeide oyvindeide enabled auto-merge (rebase) August 21, 2024 13:11
@oyvindeide oyvindeide merged commit ef64736 into equinor:main Aug 21, 2024
33 of 34 checks passed
@oyvindeide oyvindeide deleted the improve_warning branch August 21, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants