Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure testing #8576

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix azure testing #8576

merged 1 commit into from
Aug 27, 2024

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Aug 27, 2024

Issue

test_that_no_error_thrown_when_checking_eclipse_version_and_no_ecl_config_defined is failing on azure.

https://github.com/equinor/komodo-releases/actions/runs/10570071389/job/29284245096

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (4bbfd5c) to head (2cdaca5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8576   +/-   ##
=======================================
  Coverage   90.75%   90.76%           
=======================================
  Files         342      342           
  Lines       20940    20940           
=======================================
+ Hits        19005    19007    +2     
+ Misses       1935     1933    -2     
Flag Coverage Δ
gui-tests 75.85% <ø> (+0.02%) ⬆️
integration-tests 53.96% <ø> (+<0.01%) ⬆️
unit-tests 68.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if more instances of this (tests that should ignore external plugins from plugin manager) show up we should think of some way to ensure that the plugin manager is "empty"

@DanSava DanSava merged commit 8511d46 into equinor:main Aug 27, 2024
35 checks passed
@DanSava DanSava deleted the fix-azure-test branch August 27, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants