Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message if something goes wrong when loading storage #8606

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Sep 2, 2024

Bacport of: #8604

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide self-assigned this Sep 2, 2024
@oyvindeide oyvindeide added the release-notes:improvement Automatically categorise as improvement in release notes label Sep 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.77%. Comparing base (f0fb2aa) to head (1e39fdb).

Files with missing lines Patch % Lines
src/ert/gui/main.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           version-10.3    #8606      +/-   ##
================================================
- Coverage         90.79%   90.77%   -0.03%     
================================================
  Files               342      342              
  Lines             20945    20961      +16     
================================================
+ Hits              19017    19027      +10     
- Misses             1928     1934       +6     
Flag Coverage Δ
gui-tests 75.61% <59.52%> (-0.21%) ⬇️
integration-tests 53.79% <42.85%> (-0.20%) ⬇️
unit-tests 68.77% <78.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@oyvindeide oyvindeide merged commit c0d8986 into equinor:version-10.3 Sep 6, 2024
35 checks passed
@oyvindeide oyvindeide deleted the storage_bug_10 branch September 6, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants