Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where runpaths were incorrect for restart runs #8607

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Sep 2, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide changed the title Fix runpaths 103 Fix bug where runpaths were hard coded Sep 2, 2024
@oyvindeide oyvindeide changed the title Fix bug where runpaths were hard coded Fix bug where runpaths were incorrect for restart runs Sep 2, 2024
@oyvindeide oyvindeide self-assigned this Sep 2, 2024
@oyvindeide oyvindeide added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Sep 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.81%. Comparing base (f0fb2aa) to head (9395ea7).

Files with missing lines Patch % Lines
src/ert/run_models/evaluate_ensemble.py 50.00% 3 Missing ⚠️
src/ert/run_models/manual_update.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           version-10.3    #8607      +/-   ##
================================================
+ Coverage         90.79%   90.81%   +0.01%     
================================================
  Files               342      342              
  Lines             20945    20948       +3     
================================================
+ Hits              19017    19023       +6     
+ Misses             1928     1925       -3     
Flag Coverage Δ
gui-tests 75.80% <65.00%> (-0.02%) ⬇️
integration-tests 54.00% <20.00%> (+0.02%) ⬆️
unit-tests 68.81% <35.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💯

@oyvindeide oyvindeide merged commit 5e9b0c4 into equinor:version-10.3 Sep 11, 2024
35 checks passed
@oyvindeide oyvindeide deleted the fix_runpaths_103 branch September 11, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants