Fix restart experiment by updating shapshot only #8692
Conversation
xjules
added
the
release-notes:improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8692 +/- ##
==========================================
+ Coverage 91.30% 91.35% +0.05%
==========================================
Files 342 342
Lines 20978 20982 +4
==========================================
+ Hits 19153 19168 +15
+ Misses 1825 1814 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/ert/run_models/base_run_model.py
Outdated
| all_realizations = self._iter_snapshot[current_iter].reals | ||
| current_progress = 0.0 | ||
| realization_count = len(all_realizations) | ||
| # realization_count = len(all_realizations) |
There was a problem hiding this comment.
| # realization_count = len(all_realizations) |
src/ert/run_models/base_run_model.py
Outdated
| @@ -404,7 +405,10 @@ def _current_progress(self) -> tuple[float, int]: | |||
| ]: | |||
| done_realizations += 1 | |||
|
|
|||
| realization_progress = float(done_realizations) / len(all_realizations) | |||
| # realization_progress = float(done_realizations) / len(all_realizations) | |||
There was a problem hiding this comment.
| # realization_progress = float(done_realizations) / len(all_realizations) |
|
Also, should we change the button text? |
Hm, the button would become quite huge wouldn't it? :) |
Yes, we would have to rephrase it for something better 🤔 |
Fix restart test to expect the total number of realizations when restart happens Update progress bar info on total number of reals
|
New screenshot:
|
Issue
Resolves #8032
Approach
When restart happens just re-use the old snapshot model.
(Screenshot of new behavior in GUI if applicable)
The only issue is that the number of realizations (in the status bar) is different than what GUI shows.
When applicable