Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge everest examples and ert test-data #8755

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Sep 20, 2024

Issue
Resolves #8741

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Sep 20, 2024
@DanSava DanSava force-pushed the merge-everest-ert-test-data branch 3 times, most recently from b6bd7d3 to 6fdae1f Compare September 23, 2024 05:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (5ec387a) to head (d11b2d2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8755      +/-   ##
==========================================
+ Coverage   90.45%   91.44%   +0.99%     
==========================================
  Files         343      343              
  Lines       21251    21251              
==========================================
+ Hits        19222    19434     +212     
+ Misses       2029     1817     -212     
Flag Coverage Δ
cli-tests 38.90% <ø> (+0.14%) ⬆️
gui-tests 72.41% <ø> (+2.17%) ⬆️
performance-tests 49.27% <ø> (-0.01%) ⬇️
unit-tests 80.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but diff makes it seem that block_storage is not there? Should be under test-data/ert/? I suppose the test_data folder under tests/everest can be merged into this in a separate PR also.

@DanSava DanSava force-pushed the merge-everest-ert-test-data branch from 8a80b0f to 03ea0ac Compare September 23, 2024 09:39
@DanSava DanSava force-pushed the merge-everest-ert-test-data branch from 03ea0ac to d11b2d2 Compare September 23, 2024 09:54
@DanSava DanSava merged commit 391deb7 into equinor:main Sep 23, 2024
50 checks passed
@DanSava DanSava deleted the merge-everest-ert-test-data branch September 23, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge examples and test-data
4 participants