Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 3.12 x86-64 MacOS 14 build #8767

Merged

Conversation

andreas-el
Copy link
Contributor

Issue
Resolves #8764

Removes failing macOS-14-large runn erthat uses x86-64 from build-matrix.
The build already skips python 3.8, and when removing 3.12 also, the runner is left unused.

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (d535c95) to head (dde2407).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8767      +/-   ##
==========================================
+ Coverage   91.44%   91.46%   +0.01%     
==========================================
  Files         343      343              
  Lines       21256    21256              
==========================================
+ Hits        19438    19441       +3     
+ Misses       1818     1815       -3     
Flag Coverage Δ
cli-tests 38.94% <ø> (+0.04%) ⬆️
gui-tests 72.38% <ø> (-0.01%) ⬇️
performance-tests 49.27% <ø> (-0.03%) ⬇️
unit-tests 80.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-el andreas-el merged commit d726815 into equinor:main Sep 23, 2024
50 checks passed
@andreas-el andreas-el deleted the remove_mac_intel_from_build_matrix branch September 23, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ert release 11.0.0-rc0 not getting deployed to pypi
3 participants