Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when parsed PRT errors are inconsistent #8773

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Sep 23, 2024

Issue
Resolves #8650

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland marked this pull request as draft September 23, 2024 13:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.45%. Comparing base (a44408b) to head (21bae8c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8773      +/-   ##
==========================================
+ Coverage   91.40%   91.45%   +0.05%     
==========================================
  Files         343      343              
  Lines       21269    21269              
==========================================
+ Hits        19441    19452      +11     
+ Misses       1828     1817      -11     
Flag Coverage Δ
cli-tests 38.93% <ø> (+0.17%) ⬆️
gui-tests 72.41% <ø> (ø)
performance-tests 49.27% <ø> (ø)
unit-tests 80.14% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland marked this pull request as ready for review September 23, 2024 13:48
@berland berland force-pushed the warn_error_inconsistencies_eclrun branch from e655639 to 21bae8c Compare September 23, 2024 13:49
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@berland berland enabled auto-merge (rebase) September 23, 2024 14:06
@berland berland merged commit ba1ef08 into equinor:main Sep 24, 2024
50 checks passed
@berland berland deleted the warn_error_inconsistencies_eclrun branch October 9, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecl_run.py does not always find error messages
3 participants