Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid buggy hypothesis versions 6.112.3 an onwards #8891

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 7, 2024

Running the stateful storage test gives the following error with hypothesis==6.112.4:

FAILED unit_tests/storage/test_local_storage.py::TestStorage::runTest - TypeError: cannot unpack non-iterable VarReference object
Falsifying example:
state = StatefulStorageTest()
grid_0 = state.create_grid(egrid=EGrid(
    Filehead(
        0,
        2000,
        0,
        TypeOfGrid.CORNER_POINT,
        RockModel.SINGLE_PERMEABILITY_POROSITY,
        GridFormat.IRREGULAR_CORNER_POINT,
    ),
    GlobalGrid(grid_head=GridHead(type_of_grid=<TypeOfGrid.CORNER_POINT: 1>, num_x=1, num_y=1, num_z=1, grid_reference_number=1, numres=1, nseg=1, coordinate_type=<CoordinateType.CARTESIAN: 1>, lgr_start=(1, 1, 1), lgr_end=(1, 1, 1)), coord=array([0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.,
           0., 0., 0., 0., 0., 0., 0.], dtype=float32), zcorn=array([0., 0., 0., 0., 0., 0., 0., 0.], dtype=float32), actnum=None),
))
state.teardown()

You can reproduce this example by temporarily adding @reproduce_failure('6.112.4', b'AXicY2BgZCAeAAAAWgAC') as a decorator on your test case
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren changed the title Pin buggy hypothesis version 6.112.4 Avoid buggy hypothesis versions 6.112.3 an onwards Oct 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.41%. Comparing base (810bda7) to head (2091b60).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8891   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files         344      344           
  Lines       21120    21120           
=======================================
  Hits        19307    19307           
  Misses       1813     1813           
Flag Coverage Δ
cli-tests 39.58% <ø> (-0.04%) ⬇️
gui-tests 73.47% <ø> (-0.03%) ⬇️
performance-tests 50.14% <ø> (-0.02%) ⬇️
unit-tests 80.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch

@berland berland merged commit 8b3667d into equinor:main Oct 7, 2024
56 checks passed
@eivindjahren eivindjahren deleted the pin_hypothesis branch October 7, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants