Remove MPI capabilities of ecl_run #8924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
force-pushed
the
rm_ecl_run_init_mpi
branch
from
6690be4 to
826fca2
Compare
|
Blocked by https://github.com/equinor/scout/issues/1124 It is confirmed that TNO does not need the functionality for Slurm which is also removed here. |
berland
force-pushed
the
rm_ecl_run_init_mpi
branch
2 times, most recently
from
839f84f to
a22bf62
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8924 +/- ##
==========================================
- Coverage 91.65% 91.63% -0.03%
==========================================
Files 343 343
Lines 21168 21168
==========================================
- Hits 19402 19397 -5
- Misses 1766 1771 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This should be handled by the Eclipse wrapper. It is already in place for Eclipse runs, as eclrun is the default, but for Flow usage this is a breaking change
berland
force-pushed
the
rm_ecl_run_init_mpi
branch
from
a22bf62 to
515ea01
Compare
Closed
|
Part of #8997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be handled by the Eclipse wrapper. It is already in place for Eclipse runs, as eclrun is the default, but for Flow usage this is a breaking change
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable