-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and rename summary_block() #8927
Conversation
b502dfb
to
1152264
Compare
1152264
to
7bedd43
Compare
7bedd43
to
fff2832
Compare
The logic for determining stable was not correct, if the summary file was not stable after two reads, it would always timeout. Behaviour is not defined by tests.
fff2832
to
ac0cf14
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8927 +/- ##
==========================================
- Coverage 91.65% 91.64% -0.02%
==========================================
Files 343 343
Lines 21168 21162 -6
==========================================
- Hits 19402 19394 -8
- Misses 1766 1768 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
The logic for determining stable was not correct, if the summary
file was not stable after two reads, it would always timeout. Behaviour
is not defined by tests.
Issue
Part of #8925
Approach
🧠
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable