Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and rename summary_block() #8927

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 9, 2024

The logic for determining stable was not correct, if the summary
file was not stable after two reads, it would always timeout. Behaviour
is not defined by tests.

Issue
Part of #8925

Approach
🧠

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland force-pushed the summary_block branch 2 times, most recently from b502dfb to 1152264 Compare October 9, 2024 20:00
@berland berland self-assigned this Oct 10, 2024
@berland berland marked this pull request as ready for review October 10, 2024 08:23
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Oct 10, 2024
The logic for determining stable was not correct, if the summary
file was not stable after two reads, it would always timeout. Behaviour
is not defined by tests.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.64%. Comparing base (fc6244f) to head (ac0cf14).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8927      +/-   ##
==========================================
- Coverage   91.65%   91.64%   -0.02%     
==========================================
  Files         343      343              
  Lines       21168    21162       -6     
==========================================
- Hits        19402    19394       -8     
- Misses       1766     1768       +2     
Flag Coverage Δ
cli-tests 39.82% <ø> (-0.01%) ⬇️
gui-tests 73.79% <ø> (-0.04%) ⬇️
performance-tests 50.39% <ø> (-0.02%) ⬇️
unit-tests 80.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@berland berland merged commit 2453a2c into equinor:main Oct 11, 2024
56 checks passed
@berland berland mentioned this pull request Oct 15, 2024
@berland berland deleted the summary_block branch October 17, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants