Fix run_dialog second progress bar hanging #8935
Conversation
This commit fixes the issue where an experiment failure would leave the second progress bar stuck in indeterminate state. Now, the second progress bar is invisible as long as there are no realizations or if all realizations are finished.
jonathan-eq
added
the
release-notes:bug-fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8935 +/- ##
==========================================
+ Coverage 91.44% 91.58% +0.14%
==========================================
Files 344 343 -1
Lines 21122 21166 +44
==========================================
+ Hits 19314 19384 +70
+ Misses 1808 1782 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -90,9 +89,16 @@ def repaint_components(self) -> None: | |||
| def stop_waiting_progress_bar(self) -> None: | |||
| self._waiting_progress_bar.setVisible(False) | |||
|
|
|||
| def start_waiting_progress_bar(self) -> None: | |||
There was a problem hiding this comment.
Is it reasonable to write a simple test for it? Ie. self._wait_progress_bar active or not?
There was a problem hiding this comment.
I am not sure; it hanging or not will most likely go unnoticed by the users anyways. I can add a small unit test, but I do not think we should put too much effort into it.
There was a problem hiding this comment.
Hm, I see. Currently it is not tested at all. Then I guess I'll leave it up to you :)
This commit fixes the issue where an experiment failure would leave the second progress bar stuck in indeterminate state. This commit makes it so that second progress bar is invisible as long as there are no realizations or if all realizations are finished.
Issue
Resolves #8912
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable