Remove redundant/superseded Everest tests

[StephanDeHoop]

Issue
Resolves #8858

Approach
It seems, after investigating, that both the test_math_func_multiobj and test_math_func_advanced cover all the functionality of the other tests. The only exception, perhaps, is in the part of the config_minimal test where we test if the following parameter is ignored when no constraints are provided in the config file: "constraint_tolerance: 0.1 # To test that it is ignored.". We could keep the minimal test and remove only the other two for this reason? But it might seem like a stretch.

(Screenshot of new behavior in GUI if applicable)

• PR title captures the intent of the changes, and is fitting for release notes.
• Added appropriate release note label
• Commit history is consistent and clean, in line with the contribution guidelines.
• Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

• When there are user facing changes: Updated documentation
• New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
• Large PR: Prepare changes in small commits for more convenient review
• Bug fix: Add regression test for the bug
• Bug fix: Create Backport PR to latest release

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (391a25f) to head (493701d).
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8954      +/-   ##
==========================================
- Coverage   91.56%   91.55%   -0.01%     
==========================================
  Files         344      345       +1     
  Lines       21295    21302       +7     
==========================================
+ Hits        19499    19504       +5     
- Misses       1796     1798       +2     

Flag	Coverage Δ
cli-tests	39.71% <ø> (-0.01%)	⬇️
gui-tests	73.51% <ø> (-0.02%)	⬇️
performance-tests	50.28% <ø> (-0.03%)	⬇️
unit-tests	80.31% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[verveerpj]

One question, otherwise good.

[verveerpj]

Could you check if these files are used in some other test, and if not, remove them?

[StephanDeHoop]

I think they are (only) used in the documentation of Everest as examples for slowly building up the complexity of using Everest (at least the minimal one is for sure, maybe the in_constr and out_constr aren't)

[verveerpj]

But in the documentation are they explicitly referring to the file location? Because they used to be in an examples folder, but that has now become test-data, and we should not have anything there that is not used. The documentation should not refer to test-data.

[StephanDeHoop]

Sorry you are right, they are making their own ('everest_config.yml') which happens to look exactly the same as the 'config_minimal.yml'. We can delete them I guess, and also clean up the associated 'jobs' I suppose?

[verveerpj]

yes, please do. However, the associated jobs might be used by other tests. You will find out when the tests fail...

[StephanDeHoop]

The job (DISTANCE3) for in- and output constraint was used in other tests. Also, config_minimal was used in quite a lot of other tests too, so we need to keep the config file.

[verveerpj]

You will also need to squash the two commits into a single one.

[verveerpj]

Looks good. Can you squash into a single commit?