-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure non-existent gen_kw does not error in dark_storage #8956
Ensure non-existent gen_kw does not error in dark_storage #8956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment only, but otherwise good.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8956 +/- ##
==========================================
- Coverage 91.55% 91.51% -0.04%
==========================================
Files 344 344
Lines 21295 21296 +1
==========================================
- Hits 19496 19489 -7
- Misses 1799 1807 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
417a034
to
74c6954
Compare
74c6954
to
6839686
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! 🚀
Issue
Resolves #8946
Approach
Return empty dataframe when the key does not exist
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable