Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure non-existent gen_kw does not error in dark_storage #8956

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 14, 2024

Issue
Resolves #8946

Approach
Return empty dataframe when the key does not exist

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 14, 2024
@eivindjahren eivindjahren self-assigned this Oct 14, 2024
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment only, but otherwise good.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (12d2b53) to head (4713a15).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8956      +/-   ##
==========================================
- Coverage   91.55%   91.51%   -0.04%     
==========================================
  Files         344      344              
  Lines       21295    21296       +1     
==========================================
- Hits        19496    19489       -7     
- Misses       1799     1807       +8     
Flag Coverage Δ
cli-tests 39.52% <0.00%> (-0.21%) ⬇️
gui-tests 73.52% <0.00%> (-0.04%) ⬇️
performance-tests 50.32% <0.00%> (+0.01%) ⬆️
unit-tests 80.32% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren force-pushed the fix_key_error_in_plot_api branch 2 times, most recently from 417a034 to 74c6954 Compare October 14, 2024 10:45
@eivindjahren eivindjahren force-pushed the fix_key_error_in_plot_api branch from 74c6954 to 6839686 Compare October 14, 2024 10:56
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

@eivindjahren eivindjahren enabled auto-merge (rebase) October 14, 2024 11:01
@eivindjahren eivindjahren merged commit 3427fa9 into equinor:main Oct 14, 2024
56 checks passed
@eivindjahren eivindjahren mentioned this pull request Oct 14, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError in dark_storage for genkw
3 participants