Remove testing of execute bit of plugin-scripts #8999
+0
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
changed the title
berland
force-pushed
the
rm_irrelevant_test
branch
2 times, most recently
from
6bbbd84
to
32ce5aa
Compare
This test file became irrelevant after 173ba86 where no built-in forward models need the extra text file with the line EXECUTABLE somescript.xx The scripts in here still needs to be executable, but the responsibility for verifying that is now on each forward model's integration test.
berland
force-pushed
the
rm_irrelevant_test
branch
from
32ce5aa
to
9ed4673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test file became irrelevant after 173ba86 where no built-in forward models need the extra text file with the line
EXECUTABLE somescript.xx
Ert still support this format, but there is no need to verify the scripts in the Ert repo to actually be executable.
Issue
Resolves #8998
Approach
✂️
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable