Skip to content

Remove src/everest/suite.py #9033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Oct 24, 2024

Resolved broader issue of main everest control flow logic in everest.suite still being there, and not all in the baserunmodel. The current everest.suite setup is very prone to circular imports, as it imports a lot of big parts from everest.

Resolves https://github.com/equinor/komodo-releases/issues/6438

@yngve-sk yngve-sk force-pushed the 24.10.24-everest_remove-suite branch 3 times, most recently from c53fb78 to e7ba0dd Compare October 24, 2024 10:57
@yngve-sk yngve-sk changed the title Remove suite.py Remove src/everest/suite.py Oct 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.

Project coverage is 90.85%. Comparing base (a630109) to head (9cee8dc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/run_models/everest_run_model.py 35.29% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9033      +/-   ##
==========================================
- Coverage   90.93%   90.85%   -0.08%     
==========================================
  Files         352      352              
  Lines       21712    21746      +34     
==========================================
+ Hits        19743    19758      +15     
- Misses       1969     1988      +19     
Flag Coverage Δ
cli-tests 39.03% <0.00%> (-0.05%) ⬇️
gui-tests 72.55% <0.00%> (-0.12%) ⬇️
performance-tests 49.50% <0.00%> (-0.08%) ⬇️
unit-tests 79.59% <35.29%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the 24.10.24-everest_remove-suite branch 2 times, most recently from 48c07e2 to 1142296 Compare October 24, 2024 12:10
@yngve-sk yngve-sk self-assigned this Oct 24, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Remember to squash!)

@yngve-sk yngve-sk force-pushed the 24.10.24-everest_remove-suite branch from 1142296 to 9cee8dc Compare October 24, 2024 13:47
@yngve-sk yngve-sk enabled auto-merge (squash) October 24, 2024 13:56
@yngve-sk yngve-sk merged commit e4445c2 into equinor:main Oct 24, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants