Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax requirement for flaky cpu multiprocess test #9040

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 24, 2024

Issue
Resolves 🩸 with 🩹 (#8798 )

Approach
🕐

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Oct 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (64bbc7e) to head (c0bbc88).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9040   +/-   ##
=======================================
  Coverage   90.92%   90.93%           
=======================================
  Files         352      352           
  Lines       21712    21712           
=======================================
+ Hits        19742    19743    +1     
+ Misses       1970     1969    -1     
Flag Coverage Δ
cli-tests 39.12% <ø> (+0.17%) ⬆️
gui-tests 72.66% <ø> (ø)
performance-tests 49.56% <ø> (+0.01%) ⬆️
unit-tests 79.65% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@berland berland merged commit cbaaca9 into equinor:main Oct 25, 2024
56 checks passed
@berland berland deleted the less_flaky branch October 31, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants