Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty responses in MeasuredData #9045

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Oct 25, 2024

Issue
Resolves failing semeio tests

Approach
Handle case of missing responses

@yngve-sk yngve-sk changed the title return empty df for measureddata w/o responses Handle empty responses in MeasuredData Oct 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (64bbc7e) to head (d52c624).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9045      +/-   ##
==========================================
- Coverage   90.93%   90.85%   -0.08%     
==========================================
  Files         352      352              
  Lines       21712    21761      +49     
==========================================
+ Hits        19743    19771      +28     
- Misses       1969     1990      +21     
Flag Coverage Δ
cli-tests 39.04% <0.00%> (-0.04%) ⬇️
gui-tests 72.59% <50.00%> (-0.08%) ⬇️
performance-tests 49.48% <0.00%> (-0.08%) ⬇️
unit-tests 79.61% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk self-assigned this Oct 25, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have regression test for this.

@yngve-sk yngve-sk force-pushed the fixup-measureddata-logic branch 2 times, most recently from 17abec5 to cc8204e Compare October 25, 2024 10:14
@yngve-sk yngve-sk force-pushed the fixup-measureddata-logic branch from cc8204e to d52c624 Compare October 25, 2024 10:15
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yngve-sk yngve-sk enabled auto-merge (squash) October 25, 2024 10:30
@yngve-sk yngve-sk merged commit cdee929 into equinor:main Oct 25, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants