Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function #9061

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Oct 28, 2024

Simplifies maintenance.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Oct 28, 2024
@oyvindeide oyvindeide self-assigned this Oct 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.70%. Comparing base (9817d75) to head (dd1781d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9061   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files         349      349           
  Lines       21776    21768    -8     
=======================================
- Hits        19751    19744    -7     
+ Misses       2025     2024    -1     
Flag Coverage Δ
cli-tests 38.99% <0.00%> (+<0.01%) ⬆️
gui-tests 71.73% <0.00%> (+0.02%) ⬆️
performance-tests 49.28% <100.00%> (+0.03%) ⬆️
unit-tests 79.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oyvindeide oyvindeide merged commit 4e71f39 into equinor:main Oct 28, 2024
56 checks passed
@oyvindeide oyvindeide deleted the remove_unused_func branch October 28, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants