Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show obs counts correctly summary panel #9065

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

yngve-sk
Copy link
Contributor

Issue
Resolves #9058

Screenshot 2024-10-28 at 12 47 22 Screenshot 2024-10-28 at 12 47 46

@yngve-sk yngve-sk self-assigned this Oct 28, 2024
@yngve-sk yngve-sk force-pushed the w44-bugfix-numobs-gui-smry branch from 32f57c5 to ac081c6 Compare October 28, 2024 11:53
@yngve-sk yngve-sk force-pushed the w44-bugfix-numobs-gui-smry branch from ac081c6 to 5978fae Compare October 28, 2024 12:16
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.64%. Comparing base (9817d75) to head (5978fae).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9065      +/-   ##
==========================================
- Coverage   90.70%   90.64%   -0.06%     
==========================================
  Files         349      349              
  Lines       21776    21779       +3     
==========================================
- Hits        19751    19741      -10     
- Misses       2025     2038      +13     
Flag Coverage Δ
cli-tests 38.81% <0.00%> (-0.18%) ⬇️
gui-tests 71.68% <100.00%> (-0.03%) ⬇️
performance-tests 49.25% <41.66%> (+<0.01%) ⬆️
unit-tests 79.53% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yngve-sk yngve-sk enabled auto-merge (squash) October 30, 2024 12:10
@yngve-sk yngve-sk merged commit f934735 into equinor:main Oct 30, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observations summary in the GUI is showing the wrong number of observations
3 participants