Have CopyDebugInfoButton change text to Copied... on click
#9119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
added
the
release-notes:improvement
jonathan-eq
force-pushed
the
improve-copy-debug-info-button
branch
from
f48a33c to
2908de4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9119 +/- ##
==========================================
- Coverage 90.75% 90.75% -0.01%
==========================================
Files 350 350
Lines 21778 21799 +21
==========================================
+ Hits 19764 19783 +19
- Misses 2014 2016 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andreas-el
reviewed
Oct 31, 2024
src/ert/gui/simulation/run_dialog.py
Outdated
| self.setFixedWidth(140) | ||
|
|
||
| def alternate_button_text_on_click_and_call_callback() -> None: | ||
| self.setText("Copied...") |
There was a problem hiding this comment.
Consider alternatives like;
Copied!
Copied to clipboard!
Copied to clipboard
There was a problem hiding this comment.
I tried the alternatives, but I think Copied.. looks better
andreas-el
reviewed
Oct 31, 2024
andreas-el
reviewed
Oct 31, 2024
tests/ert/unit_tests/gui/ertwidgets/test_copy_debug_info_button.py
Outdated
Show resolved
Hide resolved
andreas-el
approved these changes
Oct 31, 2024
jonathan-eq
force-pushed
the
improve-copy-debug-info-button
branch
from
2908de4 to
26959fd
Compare
This commit refactors the copydebuginfobutton in run_dialog.py into its own class, and makes it change text `Copy Debug Info" -> `Copied...` when clicked while running the callback passed to it. After one second, it changes it text back to `Copy Debug Info`.
jonathan-eq
force-pushed
the
improve-copy-debug-info-button
branch
from
26959fd to
2f2e5d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the copydebuginfobutton in run_dialog.py into its own class, and makes it change text
Copy Debug Info->Copied...when clicked while running the callback passed to it. After one second, it changes it text back toCopy Debug Info.Approach
🚠
(Screenshot of new behavior in GUI if applicable)
Screen.Recording.2024-10-31.at.15.06.59.mov
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable