Have ensemble fail early when problems on initial connection to ensemble evaluator #9139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
added
the
release-notes:bug-fix
jonathan-eq
force-pushed
the
fix-firewall-issue-reporting
branch
3 times, most recently
from
6d89bdb to
5de2c3b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9139 +/- ##
==========================================
+ Coverage 90.75% 90.77% +0.01%
==========================================
Files 352 352
Lines 21934 21938 +4
==========================================
+ Hits 19906 19914 +8
+ Misses 2028 2024 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonathan-eq
force-pushed
the
fix-firewall-issue-reporting
branch
2 times, most recently
from
76beae0 to
31f3f0c
Compare
This commit fixes the issue where monitor would be hanging for 120 seconds until timeout even if `wait_for_evaluator` already failed in the receiver task.
jonathan-eq
force-pushed
the
fix-firewall-issue-reporting
branch
from
31f3f0c to
dc328e3
Compare
dafeda
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue where monitor would be hanging for 120 seconds until timeout even if
wait_for_evaluatoralready failed in the receiver task.Before this commit, the tests would also be hanging if firewall issues, now they all fail instead which is the desired behavior.
Issue
Resolves #9124
Approach
⛵ 🌊
(Screenshot of new behavior in GUI if applicable)
Screen.Recording.2024-11-04.at.13.49.41.mov
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable