Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze websockets at < 14 #9171

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Nov 11, 2024

New version of websockets is incompatible with our current code

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

New version is incompatible with our current code
@JHolba JHolba self-assigned this Nov 11, 2024
@JHolba JHolba added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (cb243b1) to head (8a07c91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9171      +/-   ##
==========================================
- Coverage   90.76%   90.75%   -0.01%     
==========================================
  Files         351      352       +1     
  Lines       21903    21934      +31     
==========================================
+ Hits        19880    19907      +27     
- Misses       2023     2027       +4     
Flag Coverage Δ
cli-tests 39.23% <ø> (-0.01%) ⬇️
gui-tests 71.77% <ø> (-0.01%) ⬇️
performance-tests 49.37% <ø> (-0.01%) ⬇️
unit-tests 79.67% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@jonathan-eq jonathan-eq merged commit a7559fd into equinor:main Nov 11, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants