Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use snapshots for everest export tests #9180

Conversation

yngve-sk
Copy link
Contributor

Issue
Resolves #9179

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@yngve-sk yngve-sk force-pushed the 24.11.12.make-everest-export-tests-into-csv-snapshot-tests branch from 94f4735 to 3df47eb Compare November 12, 2024 09:09
@yngve-sk yngve-sk marked this pull request as ready for review November 12, 2024 09:09
@yngve-sk yngve-sk force-pushed the 24.11.12.make-everest-export-tests-into-csv-snapshot-tests branch 4 times, most recently from f33a933 to 2c23eb8 Compare November 12, 2024 09:35
@yngve-sk yngve-sk force-pushed the 24.11.12.make-everest-export-tests-into-csv-snapshot-tests branch from 2c23eb8 to aa54268 Compare November 12, 2024 09:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (3fec61f) to head (647ab03).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9180      +/-   ##
==========================================
+ Coverage   90.74%   90.77%   +0.02%     
==========================================
  Files         352      352              
  Lines       21937    21935       -2     
==========================================
+ Hits        19907    19911       +4     
+ Misses       2030     2024       -6     
Flag Coverage Δ
cli-tests 39.25% <ø> (+0.01%) ⬆️
gui-tests 71.75% <ø> (+<0.01%) ⬆️
performance-tests 49.36% <ø> (+<0.01%) ⬆️
unit-tests 79.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@yngve-sk yngve-sk merged commit f088b4b into equinor:main Nov 12, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use snapshots in test_export.py
3 participants