Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python3.8 #9215

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Drop support for Python3.8 #9215

merged 2 commits into from
Nov 14, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Nov 14, 2024 •
edited
Loading

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Nov 14, 2024
@oyvindeide oyvindeide self-assigned this Nov 14, 2024
sondreso
sondreso approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3️⃣ 🎱

@oyvindeide oyvindeide enabled auto-merge (rebase) November 14, 2024 10:42
@oyvindeide oyvindeide merged commit 91310f9 into equinor:main Nov 14, 2024
42 checks passed
@oyvindeide oyvindeide deleted the drop_3_8 branch November 14, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreso sondreso sondreso approved these changes

Assignees

@oyvindeide oyvindeide

Labels
release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oyvindeide @sondreso