Fix walltime computation bug #9234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we logged finished step events before the current batch of events were processed, there were situations where the snapshot from a previous failed realization was out of date. This solves that problem. There is still a residual problem that will surface if walltime is to be computed for all steps: If a failure event for a step and its success event from the subsequent run is in the same batch of events, we can get a negative walltime computed. This problem is ignored as the walltime computation is only interesting (currently) for walltimes > 120 seconds, where this cannot happen (max time between batches is 2 seconds).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## version-11.1 #9234 +/- ##
================================================
- Coverage 90.85% 90.83% -0.02%
================================================
Files 352 352
Lines 21959 21960 +1
================================================
- Hits 19950 19947 -3
- Misses 2009 2013 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Backporting to solve #9216 for 11.1
Approach
🍒
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable