-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pattern matching for config schema #9238
Use pattern matching for config schema #9238
Conversation
This change will make it slightly more awkward to backport any future critical bugfix into the 3.8 code. |
Yes, we talked a bit about this at the office. We can discuss it after lunch and decide what to do then. |
We will just wait until backporting python 3.8 fixes is less urgent. |
26a607f
to
922e5f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9238 +/- ##
===========================================
+ Coverage 34.73% 91.83% +57.09%
===========================================
Files 431 434 +3
Lines 26714 26765 +51
===========================================
+ Hits 9279 24579 +15300
+ Misses 17435 2186 -15249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Use pattern matching now that we no longer support python 3.9
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable