Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pattern matching for config schema #9238

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Nov 18, 2024

Use pattern matching now that we no longer support python 3.9

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren self-assigned this Nov 18, 2024
@eivindjahren eivindjahren added the release-notes:refactor PR changes code without changing ANY (!) behavior. label Nov 18, 2024
@berland
Copy link
Contributor

berland commented Nov 18, 2024

This change will make it slightly more awkward to backport any future critical bugfix into the 3.8 code.

@eivindjahren
Copy link
Contributor Author

This change will make it slightly more awkward to backport any future critical bugfix into the 3.8 code.

Yes, we talked a bit about this at the office. We can discuss it after lunch and decide what to do then.

@eivindjahren
Copy link
Contributor Author

We will just wait until backporting python 3.8 fixes is less urgent.

@eivindjahren eivindjahren force-pushed the use_pattern_matching_for_schema_item.py branch from 26a607f to 922e5f2 Compare December 9, 2024 14:38
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.93671% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (ad786d8) to head (922e5f2).

Files with missing lines Patch % Lines
src/ert/config/parsing/config_schema_item.py 97.10% 2 Missing ⚠️
src/ert/config/parsing/schema_dict.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9238       +/-   ##
===========================================
+ Coverage   34.73%   91.83%   +57.09%     
===========================================
  Files         431      434        +3     
  Lines       26714    26765       +51     
===========================================
+ Hits         9279    24579    +15300     
+ Misses      17435     2186    -15249     
Flag Coverage Δ
cli-tests 39.37% <69.62%> (?)
everest-models-test 34.73% <48.10%> (+<0.01%) ⬆️
gui-tests 72.12% <64.55%> (?)
integration-test 36.98% <46.83%> (?)
performance-tests 51.91% <56.96%> (?)
test 40.67% <46.83%> (?)
unit-tests 74.03% <94.93%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@eivindjahren eivindjahren merged commit 602a9b2 into equinor:main Dec 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:refactor PR changes code without changing ANY (!) behavior.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants