Fix ecl not able to parce errors from MPI runs #9248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HakonSohoel
added
the
release-notes:bug-fix
andreas-el
reviewed
Nov 19, 2024
| ), | ||
| ], | ||
| ) | ||
| def test_can_parce_errors_when_eclipse_uses_multiple_cpus( |
andreas-el
reviewed
Nov 19, 2024
|
|
||
| run = ecl_run.EclRun("ECLCASE.DATA", "dummysimulatorobject") | ||
| error_list = run.parseErrors() | ||
| assert error_list == expected_error_list |
There was a problem hiding this comment.
Possible to simplify some, since the expected output is the list of the input?
You could probably test against [prt_error] and trim away a lot in the parameter section for the test.
There was a problem hiding this comment.
Yes, would have been possible with the simple tests where prt_error only contains one message. I've added a test with a prt_error log containing a mix of messages, where only some will be included in the error_list to verify that the parseErrors function correctly extracts only the parts we're interested in.
HakonSohoel
deleted the
fix-ecl_run-not-able-to-parse-errors-from-MPI-runs
branch
berland
pushed a commit
to berland/ert
that referenced
this pull request
Nov 22, 2024
berland
pushed a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9237
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable