Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pattern matching for make_summary_key #9262

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Use pattern matching for make_summary_key #9262

merged 1 commit into from
Dec 9, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Nov 19, 2024 •
edited
Loading

Use pattern matching for make_summary_key

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren force-pushed the use_pattern_matching_fr_make_summary_key branch from 69df926 to 908b4c8 Compare November 19, 2024 12:57
@eivindjahren eivindjahren added the release-notes:refactor PR changes code without changing ANY (!) behavior. label Nov 19, 2024
@eivindjahren eivindjahren self-assigned this Dec 9, 2024
andreas-el
andreas-el approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🌥️

@eivindjahren eivindjahren merged commit ad786d8 into equinor:main Dec 9, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-el andreas-el andreas-el approved these changes

Assignees

@eivindjahren eivindjahren

Labels
release-notes:refactor PR changes code without changing ANY (!) behavior.
Projects
SCOUT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eivindjahren @andreas-el