Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize ert config with plugins when starting webviz ert #9267

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Nov 19, 2024

Issue
Resolves #9251

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules
Copy link
Contributor

xjules commented Nov 21, 2024

Hm, seems like we need to update dependencies:

    _import_error_message = (
        "dask.distributed is not installed.\n\n"
        "Please either conda or pip install distributed:\n\n"
        "  conda install dask distributed             # either conda install\n"
        '  python -m pip install "dask[distributed]" --upgrade    # or pip install'
    )
    
    try:
        from distributed import *
    except ImportError as e:
        if e.msg == "No module named 'distributed'":
>           raise ImportError(_import_error_message) from e
E           ImportError: dask.distributed is not installed.
E           
E           Please either conda or pip install distributed:
E           
E             conda install dask distributed             # either conda install
E             python -m pip install "dask[distributed]" --upgrade    # or pip install

@xjules
Copy link
Contributor

xjules commented Nov 25, 2024

You have some errors and btw:

tests/ert/unit_tests/test_tracking.py::test_run_information_present_as_env_var_in_fm_context[ensemble_smoother]
tests/ert/unit_tests/test_tracking.py::test_run_information_present_as_env_var_in_fm_context[ensemble_smoother]
  /Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/subprocess.py:224: RuntimeWarning: Using fork() can cause Polars to deadlock in the child process.
  In addition, using fork() with Python in general is a recipe for mysterious
  deadlocks and crashes.

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @larsevj! 🚀

@larsevj larsevj added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Nov 26, 2024
@larsevj larsevj merged commit d7829ac into equinor:main Nov 26, 2024
42 checks passed
@larsevj larsevj deleted the fix_ert_vis branch November 26, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webviz-ert crashes on startup if you try to use any ert-internal forward models
2 participants