Fix ambiguous find_unsmry() #9300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
added
the
release-notes:bug-fix
eivindjahren
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Seems like the new test is flaky:
FAILED tests/ert/unit_tests/resources/test_ecl_run_new_config.py::test_find_unsmry[paths_to_touch11-SPE1-ValueError] - Failed: DID NOT RAISE <class 'ValueError'>
https://github.com/equinor/ert/actions/runs/11955842976/job/33364180931?pr=9300
Oh no, case insensitive filesystem on Mac. |
This solves a bug where find_unsmry() would not be able to locate the correct summary file even if it has the correct base for the Eclipse deck
berland
force-pushed
the
fix_ambig_unsmry
branch
from
97412f5 to
f41f00a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9277
Approach
Solve old bug that old code tucked under the carpet.
To reproduce this problem you need to run Eclipse with more than 1 CPU and also leave a similar looking UNSMRY-file to the runpath.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable