Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow sel in save_parameters #9327

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Nov 25, 2024

Issue
Resolves #3917
Resolves #3914

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

yngve-sk
yngve-sk previously approved these changes Nov 25, 2024
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xjules
Copy link
Contributor

xjules commented Nov 25, 2024

LGTM

I wouldn't be so rushed in this case ...

@yngve-sk
Copy link
Contributor

LGTM

I wouldn't be so rushed in this case ...

Ohh. LGTM was intended only for first 2 commits

@yngve-sk yngve-sk dismissed their stale review November 25, 2024 11:31

more stuff was added

@eivindjahren eivindjahren force-pushed the fix_slow_sel branch 4 times, most recently from b67c563 to 4d2487b Compare November 25, 2024 14:01
@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Nov 25, 2024
@eivindjahren eivindjahren merged commit 6a4bcd2 into equinor:main Nov 25, 2024
42 checks passed
@eivindjahren eivindjahren deleted the fix_slow_sel branch November 25, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky tests/ert/ui_tests/cli/test_field_parameter.py::test_field_param_update_using_heat_equation
3 participants