Have fm_runner's event reporter shutdown gracefully #9365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
added
release-notes:bug-fix
jonathan-eq
force-pushed
the
main5
branch
3 times, most recently
from
14089e2 to
0834495
Compare
xjules
reviewed
Nov 27, 2024
xjules
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Very nice @jonathan-eq ! Could you squash the commits as I think they are dependent regardless.
This commit fixes the issue where the logs would be spammed with errors related to the websocket client being forcefully shut down before closing the connection. It also fixes the issue where the fm_runner was not killing the running forward models when sigterm was signaled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9041
Approach
This PR makes the forward model runner shut down more gracefully, and fixes a bug where FMs would live on after terminate experiment had been pressed.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable