Suppress everest logger output to the console #9371
Conversation
verveerpj
force-pushed
the
fix-loggin
branch
2 times, most recently
from
b666b8a to
ad6861b
Compare
|
Unfortunately, it has proven difficult to write a test for this, because Therefore I will not write a test. If we experience a regression with this issue, it will become evident immediately since it will show up in the console. |
| log_level=logging.INFO, | ||
| ) | ||
| def _configure_loggers(config: EverestConfig) -> None: | ||
| def _make_handler(path: Path, log_level: str | int = "INFO") -> dict[str, Any]: |
There was a problem hiding this comment.
Nitpicky comment: I would rename this to make_handler_config
| ) | ||
| detached_dir = Path(ServerConfig.get_detached_node_dir(config.output_dir)) | ||
| log_dir = Path(config.log_dir) | ||
| logging_dict = { |
There was a problem hiding this comment.
Would you consider naming this logging_config?
| file_path=os.path.join(detached_node_dir, "endpoint.log"), | ||
| log_level=logging.INFO, | ||
| ) | ||
| def _configure_loggers(config: EverestConfig) -> None: |
There was a problem hiding this comment.
Is it possible for this function to only get the required components from EverestConfig and not the entire object?
verveerpj
force-pushed
the
fix-loggin
branch
from
ad6861b to
0419bb6
Compare
verveerpj
force-pushed
the
fix-loggin
branch
from
0419bb6 to
1b3c354
Compare
Issue
Resolves #9269
Approach
Redo logging setup using dict configuration, which mysteriously fixes the issue.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable