Migrate finalized keys for response configs #9375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
24.11.28.add-missing-migration
branch
5 times, most recently
from
9f2d24a to
a26e843
Compare
yngve-sk
force-pushed
the
24.11.28.add-missing-migration
branch
from
dd87b9c to
b070662
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9375 +/- ##
==========================================
- Coverage 91.86% 91.85% -0.01%
==========================================
Files 433 434 +1
Lines 26654 26724 +70
==========================================
+ Hits 24486 24548 +62
- Misses 2168 2176 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
oyvindeide
reviewed
Dec 5, 2024
.../ert/unit_tests/storage/snapshots/test_storage_migration/test_that_storage_matches/responses
Show resolved
Hide resolved
oyvindeide
reviewed
Dec 5, 2024
yngve-sk
force-pushed
the
24.11.28.add-missing-migration
branch
4 times, most recently
from
57f514d to
59d04aa
Compare
oyvindeide
reviewed
Dec 6, 2024
oyvindeide
reviewed
Dec 6, 2024
oyvindeide
reviewed
Dec 6, 2024
oyvindeide
reviewed
Dec 6, 2024
yngve-sk
force-pushed
the
24.11.28.add-missing-migration
branch
from
208d8bb to
a413275
Compare
yngve-sk
force-pushed
the
24.11.28.add-missing-migration
branch
from
9de58bf to
7b3d208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required with b5d2b40
otherwise we get migrated response configs that are missing
has_finalized_keys