Ignore erroneous auto-scale configuration, but warn #9390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
added
the
release-notes:bug-fix
berland
force-pushed
the
ignore_auto_scale_error
branch
from
aa3bcd1 to
fac0dd6
Compare
test-data/ert/poly_example/poly.ert
Outdated
| @@ -6,9 +6,11 @@ RUNPATH poly_out/realization-<IENS>/iter-<ITER> | |||
| OBS_CONFIG observations | |||
| REALIZATION_MEMORY 50mb | |||
|
|
|||
| NUM_REALIZATIONS 100 | |||
| NUM_REALIZATIONS 10 | |||
There was a problem hiding this comment.
Don't think we should change anything in the test-data. Maybe we could instead just edit this in the test.
There was a problem hiding this comment.
this is just a boo-boo, will fix. Note to self, remove git commit -a from muscle memory.
There was a problem hiding this comment.
No problem, it was just in the ready for review column so thought I would comment on it for safety.
eivindjahren
requested changes
Nov 29, 2024
berland
force-pushed
the
ignore_auto_scale_error
branch
from
fac0dd6 to
db05829
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9390 +/- ##
=======================================
Coverage 91.85% 91.86%
=======================================
Files 433 433
Lines 26655 26659 +4
=======================================
+ Hits 24485 24491 +6
+ Misses 2170 2168 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9339
Approach
Detect and ignore (but warn)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable