Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not being able to select other realizations than 0 in run dialog #9391

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Nov 28, 2024

See https://equinor.slack.com/archives/C01MCMWD075/p1732804737440049

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj self-assigned this Nov 28, 2024
@larsevj larsevj added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Nov 28, 2024
@larsevj
Copy link
Contributor Author

larsevj commented Nov 28, 2024

Struggling to write a test for this.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (0ba0626) to head (7deb66f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9391   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         433      433           
  Lines       26657    26658    +1     
=======================================
+ Hits        24488    24490    +2     
+ Misses       2169     2168    -1     
Flag Coverage Δ
cli-tests 39.41% <0.00%> (-0.01%) ⬇️
everest-models-test 34.83% <0.00%> (-0.01%) ⬇️
gui-tests 72.37% <100.00%> (+0.03%) ⬆️
integration-test 37.13% <0.00%> (-0.03%) ⬇️
performance-tests 52.07% <100.00%> (-0.02%) ⬇️
test 40.52% <0.00%> (-0.01%) ⬇️
unit-tests 74.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@larsevj larsevj merged commit 471df83 into equinor:main Dec 5, 2024
39 checks passed
@larsevj larsevj deleted the fix_selected_real branch December 5, 2024 08:51
@larsevj larsevj mentioned this pull request Dec 6, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants