Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the azure logging handler in Everest #9402

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix the azure logging handler in Everest #9402

merged 2 commits into from
Dec 3, 2024

Conversation

verveerpj
Copy link
Contributor

Issue
The azure logging handler in Everest was broken by a recent change.

Approach
The handler string should point to an accessible function, made the handler a global in the everserver module and adjusted the log config accordingly.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (5dbaae5) to head (e936372).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/everest/detached/jobs/everserver.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9402      +/-   ##
==========================================
- Coverage   91.86%   91.85%   -0.01%     
==========================================
  Files         433      433              
  Lines       26664    26665       +1     
==========================================
  Hits        24494    24494              
- Misses       2170     2171       +1     
Flag Coverage Δ
cli-tests 39.41% <ø> (-0.01%) ⬇️
everest-models-test 34.82% <0.00%> (-0.01%) ⬇️
gui-tests 72.36% <ø> (+0.02%) ⬆️
integration-test 37.13% <80.00%> (-0.01%) ⬇️
performance-tests 52.09% <ø> (+0.02%) ⬆️
test 40.52% <80.00%> (+<0.01%) ⬆️
unit-tests 74.02% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@DanSava DanSava merged commit 13fdda2 into main Dec 3, 2024
41 checks passed
@DanSava DanSava deleted the fix-azure-handler branch December 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants