Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ropt to 0.10.0 #9405

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Update ropt to 0.10.0 #9405

merged 2 commits into from
Dec 2, 2024

Conversation

verveerpj
Copy link
Contributor

@verveerpj verveerpj commented Dec 2, 2024

Issue
Update to ropt==0.10.0.

There are two breaking changes that my affect existing PRs:

  • In the ropt configuration objective_functions has been renamed to objectives
  • The to_dataframe method of result objects now take only a single argument, the name of the field to export. The config argument has been removed.

After merging, a PR in Komodo will be submitted to update bleeding.

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@verveerpj verveerpj added release-notes:dependency Automatically categorise as dependency change in release notes everest labels Dec 2, 2024
@verveerpj verveerpj self-assigned this Dec 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (c9fc8d3) to head (e0dcb4f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9405      +/-   ##
==========================================
- Coverage   90.42%   90.39%   -0.04%     
==========================================
  Files         349      349              
  Lines       21890    21890              
==========================================
- Hits        19794    19787       -7     
- Misses       2096     2103       +7     
Flag Coverage Δ
cli-tests 39.29% <ø> (ø)
gui-tests 72.12% <ø> (+0.02%) ⬆️
performance-tests 50.85% <ø> (+<0.01%) ⬆️
unit-tests 79.16% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@verveerpj verveerpj merged commit 3a84a98 into main Dec 2, 2024
81 of 82 checks passed
@verveerpj verveerpj deleted the update-ropt branch December 2, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
everest release-notes:dependency Automatically categorise as dependency change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants