Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have ModelConfig output better warning when malformatted runpath #9408

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Dec 2, 2024

Issue
Resolves #9313

Approach
This commit makes ModelConfig emit a ConfigWarning if the input runpath does not contain <ITER> or <IENS>. This was previously only a warning in the logs, but it should be more noticable.

(Screenshot of new behavior in GUI if applicable)
image

(py312-arm-venv) arm64 ➜  ert git:(improve-runpath-validation) ✗ ert ensemble_experiment test-data/ert/snake_oil/snake_oil.ert --disable-monitor
RUNPATH keyword contains no value placeholders: `/Users/JONAK/Documents/FMU/SCOUT/ert/test-data/ert/snake_oil/storage/snake_oil/runpath/realization-IENS/iter-ITER`. Valid example: `simulations/realization-<IENS>/iter-<ITER>` 
Config contains a SUMMARY key but no forward model steps known to generate a summary file
Warning: ERT is running in an existing runpath.
Please be aware of the following:
- Previously generated results might be overwritten.
- Previously generated files might be used if not configured correctly.
- 1 out of 25 realizations are running in existing runpaths.

(py312-arm-venv) arm64 ➜  ert git:(improve-runpath-validation) ✗ 
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq force-pushed the improve-runpath-validation branch from 7c5446f to de45683 Compare December 2, 2024 13:04
@jonathan-eq jonathan-eq added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Dec 2, 2024
This commit makes ModelConfig emit a ConfigWarning if the input runpath does not contain `<ITER>` or `<IENS>`. This was previously only a warning in the logs, but it should be more noticable.
@jonathan-eq jonathan-eq force-pushed the improve-runpath-validation branch from de45683 to b7154a8 Compare December 2, 2024 13:08
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@jonathan-eq jonathan-eq merged commit 726a273 into equinor:main Dec 6, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected failures if runpath string is not properly formatted
2 participants