Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Everest tests using snake_oil configs #9409

Merged
merged 34 commits into from
Dec 5, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Dec 2, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide force-pushed the simplify_test branch 4 times, most recently from 6b47307 to 748e279 Compare December 3, 2024 08:36
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (309a535) to head (1eec651).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9409      +/-   ##
==========================================
+ Coverage   91.85%   91.87%   +0.01%     
==========================================
  Files         433      433              
  Lines       26661    26656       -5     
==========================================
  Hits        24489    24489              
+ Misses       2172     2167       -5     
Flag Coverage Δ
cli-tests 39.41% <ø> (+<0.01%) ⬆️
everest-models-test 34.82% <0.00%> (-0.01%) ⬇️
gui-tests 72.37% <ø> (+0.03%) ⬆️
integration-test 37.11% <100.00%> (-0.02%) ⬇️
performance-tests 52.07% <ø> (+<0.01%) ⬆️
test 40.76% <100.00%> (+0.26%) ⬆️
unit-tests 74.02% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Massive cleanup! 🧹

@oyvindeide oyvindeide force-pushed the simplify_test branch 2 times, most recently from b535e4f to d5a65ba Compare December 4, 2024 12:08
@oyvindeide oyvindeide force-pushed the simplify_test branch 4 times, most recently from 385d7dc to 98d86db Compare December 5, 2024 09:06
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 5, 2024
@oyvindeide oyvindeide changed the title Cleanup and make everest_to_res test more explicit Refactor Everest tests using snake_oil configs Dec 5, 2024
@oyvindeide oyvindeide enabled auto-merge (rebase) December 5, 2024 09:21
@oyvindeide oyvindeide merged commit 6c86e6a into equinor:main Dec 5, 2024
39 checks passed
@oyvindeide oyvindeide deleted the simplify_test branch December 5, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants