Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forkserver instead of fork for multiprocessing #9411

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Dec 2, 2024

Polars gives warnings if using fork.
preexec_fn in create_subprocess_exec is unsafe using fork.
python 3.14 will set forkserver as default on linux/bsd.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@JHolba JHolba self-assigned this Dec 2, 2024
@JHolba JHolba added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Dec 2, 2024
Polars gives warnings if using fork.
preexec_fn in create_subprocess_exec is unsafe using fork.
python 3.14 will set forkserver as default on linux/bsd.
@JHolba JHolba force-pushed the switch-to-forkserver branch from 79ac49a to 3ec52e2 Compare December 2, 2024 13:54
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this resolves the polars warning, I am all for it.

@JHolba JHolba merged commit c4b5b67 into equinor:main Dec 3, 2024
40 checks passed
@JHolba JHolba deleted the switch-to-forkserver branch December 3, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants