Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage gathering of everest #9416

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Dec 2, 2024

Adds test & coverage statistics also for everest. Result can be seen here: https://app.codecov.io/gh/equinor/ert/pull/9416

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (c9fc8d3) to head (d6f96ab).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9416      +/-   ##
==========================================
+ Coverage   90.42%   91.86%   +1.43%     
==========================================
  Files         349      433      +84     
  Lines       21890    26655    +4765     
==========================================
+ Hits        19794    24486    +4692     
- Misses       2096     2169      +73     
Flag Coverage Δ
cli-tests 39.42% <ø> (+0.13%) ⬆️
everest-models-test 34.84% <ø> (?)
gui-tests 72.37% <ø> (+0.28%) ⬆️
integration-test 37.14% <ø> (?)
performance-tests 52.08% <ø> (+1.24%) ⬆️
test 40.54% <ø> (?)
unit-tests 74.03% <ø> (-5.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren force-pushed the add_coverage_of_everest branch from b56f6d7 to d6f96ab Compare December 2, 2024 20:17
@eivindjahren eivindjahren added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 2, 2024
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖️

@andreas-el andreas-el merged commit ec8b5cc into equinor:main Dec 3, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants