Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing params to TorqueQueueOptions when creating Everest server #9431

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

cmrqs
Copy link
Contributor

@cmrqs cmrqs commented Dec 3, 2024

Issue
Resolves #9430

Approach
Added the parameters queue and keep_qsub_output to TorqueQueueOptions when creating the Everest server.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@cmrqs cmrqs force-pushed the server-torque-args-fix branch from 1aba6b3 to 6fdd906 Compare December 3, 2024 14:16
@sondreso sondreso requested a review from oyvindeide December 9, 2024 08:09
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanSava DanSava merged commit 72babc5 into equinor:main Dec 16, 2024
39 checks passed
@cmrqs cmrqs deleted the server-torque-args-fix branch December 16, 2024 11:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (a5bfbdb) to head (6cf196d).
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9431      +/-   ##
==========================================
- Coverage   91.83%   91.83%   -0.01%     
==========================================
  Files         434      434              
  Lines       26736    26736              
==========================================
- Hits        24554    24553       -1     
- Misses       2182     2183       +1     
Flag Coverage Δ
cli-tests 39.32% <ø> (ø)
everest-models-test 34.74% <0.00%> (ø)
gui-tests 72.15% <ø> (-0.01%) ⬇️
integration-test 36.99% <0.00%> (-0.03%) ⬇️
performance-tests 51.94% <ø> (-0.05%) ⬇️
test 40.69% <100.00%> (+0.02%) ⬆️
unit-tests 74.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Everest fails to submit job using OpenPBS driver
5 participants