Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python310 #9433

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Drop python310 #9433

merged 2 commits into from
Dec 4, 2024

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Dec 3, 2024

Dropping python 3.10 support

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@JHolba JHolba added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Dec 3, 2024
@JHolba JHolba self-assigned this Dec 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (309a535) to head (c50a4bd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9433      +/-   ##
==========================================
+ Coverage   91.85%   91.86%   +0.01%     
==========================================
  Files         433      433              
  Lines       26661    26657       -4     
==========================================
- Hits        24489    24488       -1     
+ Misses       2172     2169       -3     
Flag Coverage Δ
cli-tests 39.42% <100.00%> (+<0.01%) ⬆️
everest-models-test 34.83% <0.00%> (-0.01%) ⬇️
gui-tests 72.34% <100.00%> (+<0.01%) ⬆️
integration-test 37.14% <0.00%> (+<0.01%) ⬆️
performance-tests 52.18% <100.00%> (+0.11%) ⬆️
test 40.52% <0.00%> (+0.02%) ⬆️
unit-tests 74.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is no longer needed as python <3.11 is not supported anymore
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing that we already pinned ert for py38, this seems like a natural next step.
Assuming you got clearance for this, ✅

@jonathan-eq jonathan-eq requested a review from sondreso December 4, 2024 11:12
@JHolba JHolba merged commit 0ba0626 into equinor:main Dec 4, 2024
39 checks passed
@JHolba JHolba deleted the drop-python310 branch December 4, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants