Remove overriding of tempfile.tempdir #9459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9459 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 433 433
Lines 26656 26652 -4
=======================================
- Hits 24489 24487 -2
+ Misses 2167 2165 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
When the jobs are executed on the cluster, /user/run/<userid> is not set up, though XDG_RUNTIME_DIR points to it. This is not a problem for ert as it runs the main application locally, but is a problem for Everest where the main application runs on the cluster. So the way lsf logs in to the node is the reason.
oyvindeide
force-pushed
the
remove_tmp_file_override
branch
from
14e1fc7 to
a24b6f0
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the jobs are executed on the cluster, /user/run/ is not set up, though XDG_RUNTIME_DIR points to it. This is not a problem for ert as it runs the main application locally, but is a problem for Everest where the main application runs on the cluster. So the way lsf logs in to the node is the reason.
Resolves: #9447
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable